[metal] Pull out the Runtime MSL code into its own module #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: c5d7f44 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/615abcea147626000857b119 |
|
/format |
bobcao3
reviewed
Oct 6, 2021
| emit(" ListManagerData snode_lists[{}];", max_snodes_); | ||
| emit(" NodeManagerData snode_allocators[{}];", max_snodes_); | ||
| emit(" NodeManagerData::ElemIndex ambient_indices[{}];", max_snodes_); | ||
| emit(" SNodeMeta snode_metas[{}];", kMaxNumSNodes); |
There was a problem hiding this comment.
How big is kMaxNumSNodes? Will it be a concern in the future
There was a problem hiding this comment.
Good point! This is 1024 now
Line 12 in fce9108
Unfortunately the sparse runtime part cannot be easily separated into a per-root buffer yet, so all the sparse info (for multiple roots) still share a single global buffer.
bobcao3
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3018
Decoupling the runtime part from the root/SNodes, so that it is easier for us to support multiple SNode roots.
In prep for the multi-root setup, we cannot know how many SNodes there will be in the system. As a result, we just set a reasonable upper-bound of 1024:
taichi/taichi/inc/constants.h
Line 12 in fce9108
Unfortunately the sparse runtime part cannot be easily separated into a per-root buffer yet, so all the sparse info (for multiple roots) still share a single global buffer.